スキル一覧に戻る
abyssparanoia

review-pr

by abyssparanoia

By using rapid-go you can quickly start developing a great API......

18🍴 2📅 2026年1月20日
GitHubで見るManusで実行

SKILL.md


name: review-pr description: Self-review PR changes against project conventions before creating PR. Use when: (1) before creating a pull request, (2) after completing feature implementation, (3) when asked to review changes, (4) running '/review-pr' or '/self-review'. Checks domain models, repositories, handlers, tests against project rules.

PR Self-Review Guide

Review PR changes against project conventions to catch issues before creating a PR.

Review Process

1. Gather Changes      → git diff, list changed files
2. Categorize Files    → map to rule files
3. Apply Checklists    → check against rules (see references/)
4. Cross-Cutting Check → lint, tests, DI, code generation
5. Generate Summary    → report issues and status

Step 1: Gather Changes

# List changed files
git diff --name-only origin/master...HEAD

# Show detailed diff
git diff origin/master...HEAD

# Show commit history
git log origin/master...HEAD --oneline

Step 2: File Category Mapping

File PatternRule FileFocus
internal/domain/model/**domain-model.mdEntity, constructor, state methods
internal/domain/service/**domain-service.mdParam/Result, no TX
internal/domain/errors/**domain-errors.mdError naming, codes
internal/domain/repository/*.gorepository.mdInterface, query structs
internal/infrastructure/**/repository/**repository.mdImplementation, marshaller
internal/usecase/**usecase-interactor.mdInput, TX, external sync
internal/infrastructure/grpc/**/handler/**grpc-handler.mdHandler, marshaller
internal/infrastructure/dependency/**dependency-injection.mdRegistration
schema/proto/**proto-definition.mdNaming, HTTP annotations
db/**/migrations/**migration.mdUp/Down, constraints
**/*_test.gotesting.mdTable-driven, mocks
*invitation*invitation-workflow.mdStatus, expiration
*authentication*, *cognito*external-service-integration.mdClaims sync

Step 3: Apply Checklists

Detailed checklists by category are in references/checklists.md.

Read the checklist file and apply relevant sections based on changed file categories.

Step 4: Cross-Cutting Checks

Run Verification Commands

/usr/bin/make lint.go   # Lint check
/usr/bin/make test      # Test check

Code Generation Verification

  • Migrations changed → Run make migrate.up
  • Proto changed → Run make generate.buf
  • Repository interfaces changed → Run make generate.mock

Registration Verification

  • New interactors registered in dependency.go
  • New handlers added to gRPC server

Step 5: Generate Summary

## Self-Review Summary

### Files Reviewed
- `path/to/file.go` - Category: domain-model

### Issues Found

#### Critical (Must Fix)
1. **[Category]** Description
   - File: `path/to/file.go:123`
   - Rule: `rules/xxx.md`
   - Fix: Suggested fix

#### Warnings (Should Fix)
1. **[Category]** Description

### Checklist Status
- [x] Lint passes
- [x] Tests pass
- [ ] Mocks regenerated
- [x] DI registration complete

### Overall Assessment
Ready for PR / Needs fixes before PR

Common Issues

See references/common-issues.md for frequently encountered problems.

  • code-investigation - Use before this skill to understand existing patterns
  • create-pull-request - Use after this skill to create the PR

スコア

総合スコア

50/100

リポジトリの品質指標に基づく評価

SKILL.md

SKILL.mdファイルが含まれている

+20
LICENSE

ライセンスが設定されている

0/10
説明文

100文字以上の説明がある

0/10
人気

GitHub Stars 100以上

0/15
最近の活動

3ヶ月以内に更新がある

0/10
フォーク

10回以上フォークされている

0/5
Issue管理

オープンIssueが50未満

+5
言語

プログラミング言語が設定されている

+5
タグ

1つ以上のタグが設定されている

0/5

レビュー

💬

レビュー機能は近日公開予定です